jayzhan211 commented on code in PR #15149:
URL: https://github.com/apache/datafusion/pull/15149#discussion_r1996526816
##########
datafusion/sqllogictest/test_files/array.slt:
##########
@@ -3075,22 +3086,26 @@ select array_concat(
----
[1, 2, 3]
-# Concatenating Mixed types (doesn't work)
-query error DataFusion error: Error during planning: It is not possible to
concatenate arrays of different types\. Expected: List\(Field \{ name: "item",
data_type: Utf8, nullable: true, dict_id: 0, dict_is_ordered: false, metadata:
\{\} \}\), got: List\(Field \{ name: "item", data_type: LargeUtf8, nullable:
true, dict_id: 0, dict_is_ordered: false, metadata: \{\} \}\)
+# Concatenating Mixed types
+query ?
select array_concat(
[arrow_cast('1', 'Utf8'), arrow_cast('2', 'Utf8')],
[arrow_cast('3', 'LargeUtf8')]
);
+----
+[1, 2, 3]
-# Concatenating Mixed types (doesn't work)
-query error DataFusion error: Error during planning: It is not possible to
concatenate arrays of different types\. Expected: List\(Field \{ name: "item",
data_type: Utf8, nullable: true, dict_id: 0, dict_is_ordered: false, metadata:
\{\} \}\), got: List\(Field \{ name: "item", data_type: Utf8View, nullable:
true, dict_id: 0, dict_is_ordered: false, metadata: \{\} \}\)
+# Concatenating Mixed types
+query ?
select array_concat(
[arrow_cast('1', 'Utf8'), arrow_cast('2', 'Utf8')],
[arrow_cast('3', 'Utf8View')]
);
+----
+[1, 2, 3]
Review Comment:
it would be nice to show the type
```
select arrow_typeof(array_concat(
[arrow_cast('1', 'Utf8'), arrow_cast('2', 'Utf8')],
[arrow_cast('3', 'Utf8View')]
));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
