blaginin opened a new pull request, #15256: URL: https://github.com/apache/datafusion/pull/15256
## Which issue does this PR close? Related to https://github.com/apache/datafusion/issues/15155#issuecomment-2715406304 ## Rationale for this change We have quite a lot of code that isn't covered in tests. And it's actually easy to miss covering some case when you submit a big PR ## What changes are included in this PR? Now, when a new PR introduces untested code, a warning message will be posted. Example: [here](https://github.com/blaginin/datafusion/pull/4#issuecomment-2726555358). <img width="930" alt="Zen Browser 2025-03-15 21 21 46" src="https://github.com/user-attachments/assets/4ccdbc37-d0d1-4d4c-bd9e-74b275454799"; /> Coverage data is aggregated from: - `linux-test` - `linux-test-datafusion-cli` - `sqllogictest-postgres` - `macos-aarch64` - `test-datafusion-pyarrow` Excluded from coverage: - `datafusion-examples` — not technically tests. - `verify-benchmark-results` — IMO we shouldn't rely on them for functionality tests, those should be covered on the unit test level - `doctests` — because they requite nightly rust and I [couldn't](https://github.com/blaginin/datafusion/actions/runs/13876294634) (yet) make it work in the CI (although will try more) There are ways to make checks even more annoying (e.g. putting ❌ in CI checks). I want to do this later, but first, I want to make sure we're measuring coverage properly and others are okay with it. If that’s the case, we’ll tighten CI checks in future PRs. Absolute coverage example: https://app.codecov.io/gh/blaginin/datafusion/pull/4/tree ## Are there any user-facing changes? No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
