shruti2522 commented on PR #15255: URL: https://github.com/apache/datafusion/pull/15255#issuecomment-2727447740
> Hey! I’m a bit worried that now to understand the test you’ll need to look into two places: open the test file and also search for the snapshot file… that’s why in the example pr (#15165) I used inline snapshots. > > do you think we should use the same approach here? Hey @blaginin, you are right about this, at first I tried implementing the inline snapshots only, but I ran into errors while running tests for `run_and_compare_query` in `user_defined/user_defined_plan.rs`, since multiple tests are using it ,only the first one works because insta doesn't allow duplicate inline snapshots by default. I tried `allow_duplicates!()`, but it gets a bit tricky with async functions. So, I used snapshot files instead because they make it much easier to run multiple tests using the same query fn, also it makes it much easier to update expected outputs in the future. Maybe we can discuss some alternative approach to implement inline snapshots 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
