parthchandra commented on PR #932: URL: https://github.com/apache/datafusion-comet/pull/932#issuecomment-2735075699
> @parthchandra Consulting a question: In the current compilation script `dev/release/build-release-comet.sh`, the final invocation of the compilation command is `core-amd64-libs` and `core-arm64-libs` in the Makefile. These two commands have a significant difference from `release-nogit` in whether they include `RUSTFLAGS="-Ctarget-cpu=native"`. We know that this flag is for special CPU optimization. If we use the `dev/release/build-release-comet.sh` compilation method, it compiles both x86 and arm CPU architectures simultaneously through Docker commands, and the arm architecture is simulated. Does this mean we lose the special CPU optimizations? Would this lead to a performance drop for Comet? Should we add the `RUSTFLAGS="-Ctarget-cpu=native"` parameter under both `core-amd64-libs` and `core-arm64-libs`? Even if we do so, would the Comet compiled in the simulated ARM environment with `RUSTFLAGS="-Ctarget-cpu=native"` still not perform as well as when compiled on a real ARM physi cal machine? Per this: https://rust-lang.github.io/packed_simd/perf-guide/target-feature/rustflags.html#target-cpu I'm not entirely sure if we want to set `target-cpu=native` for the distribution. I don't know enough about the rust compiler's optimizations to know if the performance difference is considerable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
