xudong963 commented on code in PR #15296:
URL: https://github.com/apache/datafusion/pull/15296#discussion_r2002309255


##########
datafusion/expr-common/src/statistics.rs:
##########
@@ -857,6 +857,143 @@ pub fn compute_variance(
     ScalarValue::try_from(target_type)
 }
 
+/// Merges two distributions into a single distribution that represents their 
combined statistics.
+/// This creates a more general distribution that approximates the mixture of 
the input distributions.

Review Comment:
   Maybe we can add some notes to `GenericDistribution`
   
   ```
       /// # Range Guarantees
       /// The provided range is assumed to be conservative - all possible 
values of the
       /// distribution must lie within this range. However, the range itself 
might be
       /// an approximation, as the actual distribution could occupy only a 
subset of the range.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to