westhide commented on code in PR #15311:
URL: https://github.com/apache/datafusion/pull/15311#discussion_r2004474014
##########
datafusion/proto/src/physical_plan/mod.rs:
##########
@@ -247,6 +247,15 @@ impl AsExecutionPlan for protobuf::PhysicalPlanNode {
.with_file_compression_type(FileCompressionType::UNCOMPRESSED);
Ok(conf.build())
}
+ PhysicalPlanType::JsonScan(scan) => {
Review Comment:
Currently batch_size will set by `context.session_config().batch_size()`
when DataSource call `open(..)`, serialization batch_size will let the
JsonSource use client config instead of the Executor session_config in
Ballista. Should we change this behavior for all file
format(`csv`,`parquert`,`avro`...)?
https://github.com/apache/datafusion/blob/19dd46d3c65e3160c0fb949880bc3e960434e96d/datafusion/datasource/src/file_scan_config.rs#L182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
