iffyio commented on code in PR #1772:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1772#discussion_r2006914091
##########
src/parser/mod.rs:
##########
@@ -11145,17 +11145,16 @@ impl<'a> Parser<'a> {
}
/// Parse a `SET ROLE` statement. Expects SET to be consumed already.
- fn parse_set_role(&mut self, modifier: Option<Keyword>) ->
Result<Statement, ParserError> {
+ fn parse_set_role(&mut self, modifier: ContextModifier) ->
Result<Statement, ParserError> {
Review Comment:
Oh I think might have think missed this detail from the previous PR, is
there a difference between `ContextModifier::None` instead of
`Option<ContextModifier>` to represent `None`? If not it would be good to
switch to the latter per convention
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
