viirya commented on code in PR #1561:
URL: https://github.com/apache/datafusion-comet/pull/1561#discussion_r2006927110
##########
common/src/main/scala/org/apache/comet/CometConf.scala:
##########
@@ -236,17 +236,18 @@ object CometConf extends ShimCometConf {
val COMET_MEMORY_OVERHEAD: OptionalConfigEntry[Long] =
conf("spark.comet.memoryOverhead")
.doc(
"The amount of additional memory to be allocated per executor process
for Comet, in MiB, " +
- "when running in on-heap mode or when using the `fair_unified` pool in
off-heap mode. " +
+ "when running in on-heap mode. " +
"This config is optional. If this is not specified, it will be set to
" +
s"`spark.comet.memory.overhead.factor` * `spark.executor.memory`.
$TUNING_GUIDE.")
.bytesConf(ByteUnit.MiB)
.createOptional
val COMET_MEMORY_OVERHEAD_FACTOR: ConfigEntry[Double] =
conf("spark.comet.memory.overhead.factor")
- .doc("Fraction of executor memory to be allocated as additional memory
for Comet " +
- "when running in on-heap mode or when using the `fair_unified` pool in
off-heap mode. " +
- s"$TUNING_GUIDE.")
+ .doc(
+ "Fraction of executor memory to be allocated as additional memory for
Comet " +
+ "when running in on-heap mode. " +
Review Comment:
```suggestion
"when running Spark in on-heap mode. " +
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
