andygrove commented on code in PR #1563:
URL: https://github.com/apache/datafusion-comet/pull/1563#discussion_r2008287770
##########
native/core/src/parquet/schema_adapter.rs:
##########
@@ -216,57 +216,6 @@ impl SchemaMapper for SchemaMapping {
let record_batch = RecordBatch::try_new_with_options(schema, cols,
&options)?;
Ok(record_batch)
}
-
- /// Adapts a [`RecordBatch`]'s schema into one that has all the correct
output types and only
- /// contains the fields that exist in both the file schema and table
schema.
- ///
- /// Unlike `map_batch` this method also preserves the columns that
- /// may not appear in the final output (`projected_table_schema`) but may
- /// appear in push down predicates
- fn map_partial_batch(&self, batch: RecordBatch) ->
datafusion::common::Result<RecordBatch> {
Review Comment:
@mbutrovich @parthchandra fyi, I am not sure of the impact, but I figured I
would first see if any tests fail in CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
