jayzhan-synnada opened a new pull request, #15371:
URL: https://github.com/apache/datafusion/pull/15371
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #.
## Rationale for this change
DataSink in physical plan blocking us from add trait method that depends on
`datasource`, moving it to datasource is much more suitable and the role is
aligned with DataSource
After moving DataSink to datasource crate, there is circular dependency
because datasource imports catalog.
Since we need DataSinkExec for catalog, we revert the dependency in another
way. And move Session to new crate datafusion-session. catalog and datasource
will depends on session
catalog -> session
datasource -> session
catalog -> datasource
from dependency view, Session can be moved to datasource, but conceptually
it doesn't fit the role of the crate so move it out along. Also, datasource
imports catalog for Session only, so revert the dependency isn't an issue.
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
