jayzhan211 commented on issue #14618: URL: https://github.com/apache/datafusion/issues/14618#issuecomment-2747896446
I found there is a big issue for moving `TypeCoercion` into `LogicalBuilder`. We have expression rewrite API like `map_expression` and we can rewrite it after the logical plan is built. In this case having a single final type coercion rule before plan rewrite is a better idea, otherwise we need to bring schema together with `Expr` for `map_expressions` so we can recompute the types with schema every time we have a new `Expr`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
