findepi commented on PR #15390: URL: https://github.com/apache/datafusion/pull/15390#issuecomment-2748049344
Alternatively, we could change `Literal::evaluate_selection` to return null scalar when selection is empty. However, for this to be effective, it would require adding evaluate_selection implementations to any physical expressions that may contain literals. Then, using `BooleanArray` for selection would no longer be efficient, as expressions would need to scan it for true values, and deal with nullability. A new type for selection would likely be more appropriate. Anyway, this sounds not like a bug fix we need for the regression. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
