blaginin commented on code in PR #15258:
URL: https://github.com/apache/datafusion/pull/15258#discussion_r2010285393
##########
datafusion/core/src/datasource/physical_plan/parquet.rs:
##########
@@ -608,19 +609,19 @@ mod tests {
.round_trip_to_batches(vec![batch1, batch2])
.await
.unwrap();
- let expected = [
- "+-----+----+----+",
- "| c1 | c2 | c3 |",
- "+-----+----+----+",
- "| Foo | 1 | 10 |",
- "| | 2 | 20 |",
- "| bar | | |",
- "| Foo | 1 | 10 |",
- "| | 2 | 20 |",
- "| bar | | |",
- "+-----+----+----+",
- ];
- assert_batches_sorted_eq!(expected, &read);
+
+ insta::assert_snapshot!(batches_to_string(&read),@r###"
Review Comment:
same below (e.g.
https://github.com/apache/datafusion/pull/15258/files#diff-c8eebe4fb9ee7662170c6ce507ad2be92c0229b3a91a2f4431a9bfc7185a0eb9R648).
feel free to dismiss if you've checked that the returned df has the same order
always. But it not - tests will become flaky
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
