xudong963 commented on code in PR #15416: URL: https://github.com/apache/datafusion/pull/15416#discussion_r2011873162
########## datafusion/datasource/src/source.rs: ########## @@ -230,4 +231,17 @@ impl DataSourceExec { Boundedness::Bounded, ) } + + /// Downcast the `DataSourceExec` to a specific file source + pub fn downcast_to_source<T: 'static>(&self) -> Option<(&FileScanConfig, &T)> { Review Comment: Agree, `downcast_to_file_source` is better. > Also is there any need for '`static` ? Yes, compiler told me to do this lol -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org