jayzhan211 commented on code in PR #14826:
URL: https://github.com/apache/datafusion/pull/14826#discussion_r2013954619
##########
datafusion/sqllogictest/test_files/string/string_view.slt:
##########
@@ -1068,7 +1068,7 @@ EXPLAIN SELECT
FROM test;
----
logical_plan
-01)Projection: digest(test.column1_utf8view, Utf8View("md5")) AS c
+01)Projection: digest(test.column1_utf8view, Utf8("md5")) AS c
Review Comment:
we avoid casting from utf8 to utf8view
##########
datafusion/sqllogictest/test_files/array.slt:
##########
@@ -6120,14 +6120,14 @@ physical_plan
09)----------------LazyMemoryExec: partitions=1,
batch_generators=[generate_series: start=1, end=100000, batch_size=8192]
query I
-with test AS (SELECT substr(md5(i)::text, 1, 32) as needle FROM
generate_series(1, 100000) t(i))
+with test AS (SELECT substr(md5(i::text)::text, 1, 32) as needle FROM
generate_series(1, 100000) t(i))
select count(*) from test WHERE array_has([needle], needle);
----
100000
# TODO: this should probably be possible to completely remove the filter as
always true?
query TT
-explain with test AS (SELECT substr(md5(i)::text, 1, 32) as needle FROM
generate_series(1, 100000) t(i))
+explain with test AS (SELECT substr(md5(i::text)::text, 1, 32) as needle FROM
generate_series(1, 100000) t(i))
Review Comment:
md5(int64) is not supported, so the test is casted to string explicitly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
