adriangb commented on code in PR #15301:
URL: https://github.com/apache/datafusion/pull/15301#discussion_r2015103237
##########
datafusion/core/src/datasource/physical_plan/parquet.rs:
##########
@@ -1847,6 +1848,28 @@ mod tests {
writer.close().unwrap();
}
+ fn write_file_null(file: &String) {
Review Comment:
I renamed to `write_file_with_null_ids`, hope that makes more sense.
Btw I plan to add some fuzz like tests that compare the results with and
without this optimization for cases with and without nulls, multiple columns,
complex queries, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
