qstommyshu commented on issue #15398: URL: https://github.com/apache/datafusion/issues/15398#issuecomment-2756274122
> Hi [@blaginin](https://github.com/blaginin?rgh-link-date=2025-03-26T21%3A33%3A40.000Z) and [@alamb](https://github.com/alamb?rgh-link-date=2025-03-26T21%3A33%3A40.000Z) > > Just want to confirm the example test files are really just "examples", right? I also see there are more files under the _subtrait_ test cases (i.e. `emit_kind_test.rs`, `function_test.rc`,`logical_plans.rs`, etc...). > > I assume I should change all the test cases under the _subtrait_ folder for this issue, **NOT** just the ones in [consumer_integration.rs](https://github.com/apache/datafusion/blob/45ed5aa5d008f7334bf64efc708038cd0c22059e/datafusion/substrait/tests/cases/consumer_integration.rs#L226-L229), and in [roundtrip_logical_plan.rs](https://github.com/apache/datafusion/blob/45ed5aa5d008f7334bf64efc708038cd0c22059e/datafusion/substrait/tests/cases/roundtrip_logical_plan.rs#L457-L462). > > I've migrated all tests to `insta` in these two files, didn't touch other files yet. > > Please let me know if my assumption is correct. > > Thanks! I think I got it now, I need to migrate all test files under `subtrait` by looking at the changes in #15258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
