andygrove commented on PR #1483: URL: https://github.com/apache/datafusion-comet/pull/1483#issuecomment-2738004391
> This change looks good to me. It makes sense to not run these tests for `native_datafusion` if we're falling back anyway. Do you have a good example of a test or query where this new fallback logging has been helpful? I didn't make any changes to the fallback logging logic (as far as I know). The only functional difference in this PR is that we fall back to Spark instead of `native_comet` now if we cannot support `native_datafusion`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
