2010YOUY01 commented on PR #15501: URL: https://github.com/apache/datafusion/pull/15501#issuecomment-2768105998
Thank you for the review! > I think we should consider the random seed along with the runtime of this test, but otherwise it looks really nice It's using a random start seed, thread rng is only avoided in the middle, and the same rng will be propagated along the process. This way it can be both random and deterministic. See https://github.com/apache/datafusion/pull/15501#discussion_r2022130464 for more discussion. > > There are other bugs detected and it's not obvious why it fails, so now by default, it will only run with unbounded memory limit, > > Could you make a list of known issues that are preventing this fuzz test from being able to run with bounded memory limits (or a placeholder if we don't know why it fails) > > I think it would be valuable to track the progress towards "enable sort fuzzing with limited memory" as I think others would be interested in helping and we would avoid leaving a half completed test in here. I agree, filed the tracking issue https://github.com/apache/datafusion/issues/15517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
