xudong963 commented on PR #15503: URL: https://github.com/apache/datafusion/pull/15503#issuecomment-2768908865
> > > I suggest modifying the existing API, not a new one. > > > > > > Which one do you think is suitable to modify, `statistics()`? > > yes, is there something blocker? I think keeping `statistics_by_partition` as a separate API from `statistics` is the better approach for several reasons: 1. Clear separation of concerns: The two methods serve different purposes - one provides global statistics for the entire execution plan, while the other provides partition-level details. 2. Backward compatibility: Modifying statistics() to handle both cases would likely be a breaking change. 3. API clarity: Having separate methods makes the intent clearer when calling the API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
