andygrove commented on code in PR #1582:
URL: https://github.com/apache/datafusion-comet/pull/1582#discussion_r2023231379
##########
.github/workflows/pr_build.yml:
##########
@@ -76,6 +78,41 @@ jobs:
# upload test reports only for java 17
upload-test-reports: ${{ matrix.java_version == '17' }}
+ # run Comet tests for older 3.5.x releases with one java and scala versions
+ linux-test-35-minor-versions:
+ strategy:
+ matrix:
+ os: [ubuntu-latest]
+ java_version: [17]
+ test-target: [java]
+ spark-version: ['3.5']
+ spark-patch-version: ['3.5.2', '3.5.3', '3.5.4']
+ scala-version: ['2.12']
+ is_push_event:
+ - ${{ github.event_name == 'push' }}
+ fail-fast: false
+ name: ${{ matrix.os }}/java ${{ matrix.java_version
}}-spark-${{matrix.spark-patch-version}}-scala-${{matrix.scala-version}}/${{
matrix.test-target }}
+ runs-on: ${{ matrix.os }}
+ container:
+ image: amd64/rust
+ steps:
+ - uses: actions/checkout@v4
+ - name: Setup Rust & Java toolchain
+ uses: ./.github/actions/setup-builder
+ with:
+ rust-version: ${{env.RUST_VERSION}}
+ jdk-version: ${{ matrix.java_version }}
+ - if: matrix.test-target == 'rust'
+ name: Rust test steps
+ uses: ./.github/actions/rust-test
Review Comment:
I agree. We also run the rust tests for multiple spark versions which is
also redundant. I will create a follow-on PR to improve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
