geoffreyclaude commented on PR #15301:
URL: https://github.com/apache/datafusion/pull/15301#issuecomment-2772149768

   @adriangb looks super promising, especially as it paves the way for general 
dynamic filtering!
   
   I tested out your branch to see the overlap with 
https://github.com/apache/datafusion/issues/15529, and I had trouble 
understanding exactly when and how the filters got applied. I dumped the 
execution plan after running a topk query and the filters were way broader than 
what I expected.
   
   Would it be possible to add an end-to-end test as a "demo" of the feature? 
Maybe in `datafusion-examples`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to