parthchandra commented on code in PR #1600:
URL: https://github.com/apache/datafusion-comet/pull/1600#discussion_r2025216115
##########
native/spark-expr/src/hash_funcs/utils.rs:
##########
@@ -20,7 +20,10 @@
#[macro_export]
macro_rules! hash_array {
($array_type: ident, $column: ident, $hashes: ident, $hash_method: ident)
=> {
- let array = $column.as_any().downcast_ref::<$array_type>().unwrap();
+ let array = $column
+ .as_any()
+ .downcast_ref::<$array_type>()
+ .expect("downcast failed");
Review Comment:
Would it be better to include some extra (debug) information in these
messages (like the array and type that failed)?
The unwrap failing is almost always going to be an internal bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
