waynexia commented on code in PR #15327: URL: https://github.com/apache/datafusion/pull/15327#discussion_r2006592227
########## datafusion/physical-expr/src/expressions/binary.rs: ########## @@ -793,8 +793,10 @@ impl BinaryExpr { BitwiseShiftRight => bitwise_shift_right_dyn(left, right), BitwiseShiftLeft => bitwise_shift_left_dyn(left, right), StringConcat => concat_elements(left, right), - AtArrow | ArrowAt => { - unreachable!("ArrowAt and AtArrow should be rewritten to function") + AtArrow | ArrowAt | Arrow | LongArrow | HashArrow | HashLongArrow | AtAt + | HashMinus | AtQuestion | Question | QuestionAnd | QuestionPipe + | IntegerDivide => { + unreachable!("These operators should be rewritten to functions") Review Comment: I just realized `<@` and `@>` are only supported for lists 🤣 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org