EmilyMatt commented on code in PR #15613:
URL: https://github.com/apache/datafusion/pull/15613#discussion_r2031220602
##########
datafusion/execution/src/memory_pool/mod.rs:
##########
@@ -149,21 +149,48 @@ pub trait MemoryPool: Send + Sync + std::fmt::Debug {
/// For help with allocation accounting, see the [`proxy`] module.
///
/// [proxy]: datafusion_common::utils::proxy
-#[derive(Debug, PartialEq, Eq, Hash, Clone)]
+#[derive(Debug)]
Review Comment:
It is still ok technically, I think, do you think it should be made to
derive Hash normally? or maybe maintain a manual Hash implementation that will
ignore the id for now to reduce changes for the user, the Eq will still use the
id?
As for the clone_with_new_id I agree, I will add it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
