Dandandan commented on code in PR #15642: URL: https://github.com/apache/datafusion/pull/15642#discussion_r2033871133
########## datafusion/functions-aggregate/src/count.rs: ########## @@ -18,6 +18,7 @@ use ahash::RandomState; use datafusion_common::stats::Precision; use datafusion_expr::expr::WindowFunction; +use datafusion_expr::groups_accumulator::BLOCK_SIZE; Review Comment: Could be based on batch size as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
