alamb commented on code in PR #15645:
URL: https://github.com/apache/datafusion/pull/15645#discussion_r2034038864
##########
datafusion/common/src/stats.rs:
##########
@@ -433,6 +480,79 @@ fn check_num_rows(value: Option<usize>, is_exact: bool) ->
Precision<usize> {
}
}
+pub fn add_row_stats(
Review Comment:
These methods had to remain `pub` for now as they are also used in the
listing table statistics summary code. I will look into that and see if it
makes sense to do as a individual PR
##########
datafusion/common/src/stats.rs:
##########
@@ -798,4 +920,173 @@ mod tests {
distinct_count: Precision::Exact(100),
}
}
+
+ #[test]
+ fn test_merge_iter_basic() {
Review Comment:
these are just tests moved from datasource
##########
datafusion/datasource/src/statistics.rs:
##########
@@ -409,62 +409,6 @@ pub async fn get_statistics_with_limit(
Ok((result_files, statistics))
}
-/// Generic function to compute statistics across multiple items that have
statistics
-fn compute_summary_statistics<T, I>(
Review Comment:
This code was moved into `Statistics`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
