alamb commented on PR #15625:
URL: https://github.com/apache/datafusion/pull/15625#issuecomment-2785993211
Thanks @DerGut
> Interestingly, when I run clippy on the `datafusion/physical-optimizer`
crate:
I actually found it fails for me on rust 1.85 as well:
```shell
(venv) andrewlamb@Andrews-MacBook-Pro-2:~/Software/datafusion$ cargo clippy
-p datafusion-physical-optimizer
warning: parameter is only used in recursion
--> datafusion/physical-optimizer/src/aggregate_statistics.rs:48:9
|
48 | config: &ConfigOptions,
| ^^^^^^ help: if this is intentional, prefix it with an
underscore: `_config`
|
note: parameter used here
--> datafusion/physical-optimizer/src/aggregate_statistics.rs:86:42
|
86 | self.optimize(child, config).map(Transformed::yes)
| ^^^^^^
...
91 | plan.map_children(|child| self.optimize(child,
config).map(Transformed::yes))
| ^^^^^^
= help: for further information visit
https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion
= note: `#[warn(clippy::only_used_in_recursion)]` on by default
warning: `datafusion-physical-optimizer` (lib) generated 1 warning
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.31s
(venv) andrewlamb@Andrews-MacBook-Pro-2:~/Software/datafusion$
```
Any chance you could make a follow PR to fix this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
