rluvaton commented on PR #15654: URL: https://github.com/apache/datafusion/pull/15654#issuecomment-2789096604
Can you please add a test, this solves a deadlock. Can you please add the following test to make sure that the read spill does not block: create a tokio runtime with 8 blocking threads and create 9 read spills and wait for all of them to be available (same as in the `SortPreservingMergeStream`) current implementation should have a dead lock - a timeout reached, new implementation should not deadlock, the test finish) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
