alamb commented on code in PR #15466:
URL: https://github.com/apache/datafusion/pull/15466#discussion_r2031531796
##########
datafusion/core/src/test/object_store.rs:
##########
@@ -166,7 +166,7 @@ impl ObjectStore for BlockingObjectStore {
fn list(
&self,
prefix: Option<&Path>,
- ) -> BoxStream<'_, object_store::Result<ObjectMeta>> {
+ ) -> BoxStream<'static, object_store::Result<ObjectMeta>> {
Review Comment:
Due to
- https://github.com/apache/arrow-rs/pull/6619
##########
datafusion/core/src/datasource/physical_plan/arrow_file.rs:
##########
@@ -305,7 +305,7 @@ impl FileOpener for ArrowOpener {
)?;
// read footer according to footer_len
let get_option = GetOptions {
- range: Some(GetRange::Suffix(10 + footer_len)),
+ range: Some(GetRange::Suffix(10 + (footer_len as
u64))),
Review Comment:
The changes to usize/u64 are for better wasm support, see
- https://github.com/apache/arrow-rs/pull/6961
##########
datafusion/sqllogictest/test_files/expr/date_part.slt:
##########
@@ -884,7 +884,7 @@ SELECT extract(day from arrow_cast('14400 minutes',
'Interval(DayTime)'))
query I
SELECT extract(minute from arrow_cast('14400 minutes', 'Interval(DayTime)'))
----
-14400
+0
Review Comment:
due to
- https://github.com/apache/arrow-rs/pull/7189
##########
datafusion/execution/Cargo.toml:
##########
@@ -44,7 +44,7 @@ datafusion-common = { workspace = true, default-features =
true }
datafusion-expr = { workspace = true }
futures = { workspace = true }
log = { workspace = true }
-object_store = { workspace = true }
+object_store = { workspace = true, features = ["fs"] }
Review Comment:
Due to
- https://github.com/apache/arrow-rs/pull/6636
##########
datafusion/datasource-parquet/src/reader.rs:
##########
@@ -114,10 +114,11 @@ impl AsyncFileReader for ParquetFileReader {
self.inner.get_byte_ranges(ranges)
}
- fn get_metadata(
- &mut self,
- ) -> BoxFuture<'_, parquet::errors::Result<Arc<ParquetMetaData>>> {
- self.inner.get_metadata()
+ fn get_metadata<'a>(
+ &'a mut self,
+ options: Option<&'a ArrowReaderOptions>,
Review Comment:
Due to
- https://github.com/apache/arrow-rs/pull/7342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
