berkaysynnada commented on PR #15503: URL: https://github.com/apache/datafusion/pull/15503#issuecomment-2796495640
> > ```rust > > self.partitioned_statistics().combine() > > ``` > > I belive the `combine()` method can be implemented with current `compute_summary_statistics()` method easily Since we are not caching any kind of statistics, each call on that API will make the same computation over and over. > I think we could add a default implementation of statistics that just called through to partitioned-statistics which would avoid the duplication. Something like This would bring us to a better state than the current version for sure, but that's not the case now as far as I can see. I am in favor of making the API changes at once, by modifying the existing statistics(). @xudong963 have you found a chance to try it and see if it brings much challenge to update the PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
