UBarney commented on code in PR #15681:
URL: https://github.com/apache/datafusion/pull/15681#discussion_r2039290205
##########
datafusion/sqllogictest/test_files/group_by.slt:
##########
@@ -2712,8 +2712,8 @@ CREATE TABLE last_null (
val INT,
o int
) as VALUES
- (0, NULL, 9),
Review Comment:
I just made it behave like `LastValueAccumulator` 😓. But I think this PR
might not be necessary, since the current implementation in main already
matches the description in the documentation:
> Returns the last element in an aggregation group according to the
requested ordering. If no ordering is given, returns an arbitrary element from
the group.
https://datafusion.apache.org/user-guide/sql/aggregate_functions.html#last-value
Close it
##########
datafusion/sqllogictest/test_files/group_by.slt:
##########
@@ -2712,8 +2712,8 @@ CREATE TABLE last_null (
val INT,
o int
) as VALUES
- (0, NULL, 9),
Review Comment:
I just made it behave like `LastValueAccumulator` 😓. But I think this PR
might not be necessary, since the current implementation in main already
matches the description in the documentation:
> Returns the last element in an aggregation group according to the
requested ordering. If no ordering is given, returns an arbitrary element from
the group.
https://datafusion.apache.org/user-guide/sql/aggregate_functions.html#last-value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
