LucaCappelletti94 commented on code in PR #1806:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1806#discussion_r2040654851
##########
src/parser/mod.rs:
##########
@@ -7070,13 +7071,22 @@ impl<'a> Parser<'a> {
}
}
- /// Parse configuration like partitioning, clustering information during
the table creation.
+ /// Parse configuration like inheritance, partitioning, clustering
information during the table creation.
///
///
[BigQuery](https://cloud.google.com/bigquery/docs/reference/standard-sql/data-definition-language#syntax_2)
- ///
[PostgreSQL](https://www.postgresql.org/docs/current/ddl-partitioning.html)
+ /// [PostgreSQL
Partitioning](https://www.postgresql.org/docs/current/ddl-partitioning.html)
+ /// [PostgreSQL
Inheritance](https://www.postgresql.org/docs/current/ddl-inherit.html)
fn parse_optional_create_table_config(
&mut self,
) -> Result<CreateTableConfiguration, ParserError> {
+ let inherits = if dialect_of!(self is BigQueryDialect |
PostgreSqlDialect | GenericDialect)
Review Comment:
The dialect thing must have been a copy paste from the line below and then
my brain decided to drop that pointer of information - fixed as described!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
