andygrove commented on code in PR #1563:
URL: https://github.com/apache/datafusion-comet/pull/1563#discussion_r2042171775
##########
native/core/src/execution/expressions/bloom_filter_might_contain.rs:
##########
@@ -140,4 +141,8 @@ impl PhysicalExpr for BloomFilterMightContain {
Arc::clone(&children[1]),
)?))
}
+
+ fn fmt_sql(&self, _: &mut Formatter<'_>) -> std::fmt::Result {
+ unimplemented!()
+ }
Review Comment:
DataFusoin now supports a new EXPLAIN output, but this is not exposed in
Comet, so we do not need to implement these new methods.
##########
native/core/src/execution/expressions/bloom_filter_might_contain.rs:
##########
@@ -140,4 +141,8 @@ impl PhysicalExpr for BloomFilterMightContain {
Arc::clone(&children[1]),
)?))
}
+
+ fn fmt_sql(&self, _: &mut Formatter<'_>) -> std::fmt::Result {
+ unimplemented!()
+ }
Review Comment:
DataFusion now supports a new EXPLAIN output, but this is not exposed in
Comet, so we do not need to implement these new methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
