aharpervc commented on code in PR #1808:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1808#discussion_r2042196775
##########
src/parser/mod.rs:
##########
@@ -5135,6 +5146,63 @@ impl<'a> Parser<'a> {
}))
}
+ /// Parse `CREATE FUNCTION` for [SQL Server]
+ ///
+ /// [SQL Server]:
https://learn.microsoft.com/en-us/sql/t-sql/statements/create-function-transact-sql
Review Comment:
I'll do it for this PR to get it merged.
Would you be willing to have a separate discussion about normalizing that
name to `SQL Server` library-wide? The product/database itself is "SQL Server",
and the language is "Transact-SQL" (aka T-SQL). I noticed that it's mostly like
"BigQuery" rather than "Google BigQuery" and "Postgres" (or PostgreSQL) but not
"PL/PGSQL". Therefore it seems like the most "normal" way to name it would just
be "SQL Server" (or `SQLServer` for identifiers). The string "mssql" doesn't
even show up
[here](https://learn.microsoft.com/en-us/sql/sql-server/?view=sql-server-ver16)
or [here](https://en.wikipedia.org/wiki/Microsoft_SQL_Server), for reference.
Therefore it seems reasonable to me, to have SQL Server be more like
BigQuery & PostgreSQL rather than it's own separate naming system...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
