alamb commented on issue #15686: URL: https://github.com/apache/datafusion/issues/15686#issuecomment-2802965975
Here is a sql reproducer of what happens today ```sql > create table t as values (arrow_cast(x'deadbeef', 'FixedSizeBinary(4)')); 0 row(s) fetched. Elapsed 0.006 seconds. > select column1 = x'deadbeef' from t; Error during planning: Cannot infer common argument type for comparison operation FixedSizeBinary(4) = Binary ``` > Coercing the LHS to Binary is less performant. Unconditionally parsing literals as FixedSizeBytes would be a breaking change. I wonder how much less performant this in in practice 🤔 In theory we can have custom kernels with custom code for different array sizes, but I think in practice it actually ends up always checking the length I really think we should avoid a new config option if possible -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
