iffyio commented on code in PR #1811:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1811#discussion_r2043654919
##########
src/parser/mod.rs:
##########
@@ -617,6 +617,9 @@ impl<'a> Parser<'a> {
}
// `COMMENT` is snowflake specific
https://docs.snowflake.com/en/sql-reference/sql/comment
Keyword::COMMENT if self.dialect.supports_comment_on() =>
self.parse_comment(),
+ Keyword::PRINT if dialect_of!(self is MsSqlDialect) => {
Review Comment:
```suggestion
Keyword::PRINT => {
```
we can parse unconditionally?
##########
src/ast/mod.rs:
##########
@@ -4050,6 +4050,14 @@ pub enum Statement {
arguments: Vec<Expr>,
options: Vec<RaisErrorOption>,
},
+ /// ```sql
+ /// PRINT msg_str | @local_variable | string_expr
+ /// ```
+ ///
+ /// See:
https://learn.microsoft.com/en-us/sql/t-sql/statements/print-transact-sql
+ Print {
+ message: Box<Expr>,
+ },
Review Comment:
Yeah we can use a separate struct for repr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
