iffyio commented on code in PR #1812:
URL: 
https://github.com/apache/datafusion-sqlparser-rs/pull/1812#discussion_r2043661502


##########
tests/sqlparser_mysql.rs:
##########
@@ -3716,3 +3716,9 @@ fn parse_straight_join() {
         "SELECT a.*, b.* FROM table_a AS a STRAIGHT_JOIN table_b AS b ON 
a.b_id = b.id",
     );
 }
+
+#[test]
+fn parse_straight_join_without_alias() {
+    mysql()
+        .verified_stmt("SELECT a.*, b.* FROM table_a STRAIGHT_JOIN table_b AS 
b ON a.b_id = b.id");
+}

Review Comment:
   ```suggestion
       // Without table alias
       mysql()
           .verified_stmt("SELECT a.*, b.* FROM table_a STRAIGHT_JOIN table_b 
AS b ON a.b_id = b.id");
   }
   ```
   thinking we can merge this scenario into the existing test case for the 
straight join feature?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to