xudong963 commented on PR #15735: URL: https://github.com/apache/datafusion/pull/15735#issuecomment-2809341842
> I think what we need to do is return `Transformed` for `simplify_with_cycle_count`. Your change introduce additional clone > > https://github.com/apache/datafusion/blob/3818b7a290fb81ca13119058255747a1ff011239/datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs#L201-L231 Sounds good, will give a try -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
