berkaysynnada commented on PR #15566: URL: https://github.com/apache/datafusion/pull/15566#issuecomment-2811986744
> @berkaysynnada I updated the SLT tests. I'll have another review tomorrow but things I'd like to point out now: > > 1. We should still think about the `retry` parameter. Ideally we can get rid of it somehow. I'll try to improve those points now. I'll give an update then > 2. The SLT plans show a lot of updates where the position of the `FilterExec` was swapped with other operators. Unless we can unequivocally prove that the new position is better we should probably minimize the risk for this PR by minimizing the changes, meaning the FilterExec doesn't move in all of these plans. Yep, I've noticed that too, but how those plans didn't change before? We were trying to pushdown filters over RepartitionExec's and CoalesceBatches -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
