zhuqi-lucas commented on PR #15730:
URL: https://github.com/apache/datafusion/pull/15730#issuecomment-2812159650
> > ```
> > // If the plan's children have limit and the child's limit < parent's
limit, we shouldn't change the global state to true, because the children limit
will be overridden if the global state is changed.
> > ```
>
> if parent has limit, the global state would have been already satisfied
before, in these lines
>
> ```rust
> // If we have a non-limit operator with fetch capability, update global
> // state as necessary:
> if pushdown_plan.fetch().is_some() {
> if global_state.fetch.is_none() {
> global_state.satisfied = true;
> }
> ```
>
> right? So, that condition seems to guard nothing, IMO as well.
Yeah @berkaysynnada , previous we have some bugs due to no unified
DataSourceExec and MemoryExec has no limit/fetch, now it's has been fixed, so
we can remove the corner case logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
