alamb commented on code in PR #15022:
URL: https://github.com/apache/datafusion/pull/15022#discussion_r2049469308
##########
datafusion/expr-common/src/groups_accumulator.rs:
##########
@@ -106,6 +107,44 @@ impl EmitTo {
/// [`Accumulator`]: crate::accumulator::Accumulator
/// [Aggregating Millions of Groups Fast blog]:
https://arrow.apache.org/blog/2023/08/05/datafusion_fast_grouping/
pub trait GroupsAccumulator: Send {
+ /// Whether [`Self::with_group_indices_order_mode`] should be called.
+ ///
+ /// this is when the accumulator would benefit from knowing the order of
the group indices.
+ ///
+ fn group_order_sensitivity(&self) -> bool {
Review Comment:
I think having the `supports` method have most of the same name as the
method that is called makes the most sense
So for example, if other function is called in
`with_group_indices_order_mode` I think this method should be named
consistently like `supports_with_group_indices_order_mode`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
