aharpervc commented on code in PR #1809:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1809#discussion_r2050847853
##########
src/parser/mod.rs:
##########
@@ -15017,6 +15026,48 @@ impl<'a> Parser<'a> {
}
}
+ fn parse_go(&mut self) -> Result<Statement, ParserError> {
+ // previous token should be a newline (skipping non-newline whitespace)
Review Comment:
Yes, I have something like that already for parsing the batch count, which
doesn't need to look backwards and already uses peek_token_no_skip. I think
between here & your other comment on the alias function, the concern is
regarding the newline logic which looks backwards. I'll try and move that into
a helper so it can be simplified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
