xudong963 commented on code in PR #15768:
URL: https://github.com/apache/datafusion/pull/15768#discussion_r2051494486
##########
datafusion/physical-plan/src/repartition/mod.rs:
##########
@@ -233,11 +233,11 @@ impl BatchPartitioner {
///
/// The time spent repartitioning, not including time spent in `f` will be
recorded
/// to the [`metrics::Time`] provided on construction
- pub fn partition<F>(&mut self, batch: RecordBatch, mut f: F) -> Result<()>
+ pub fn partition<F>(&mut self, batches: Vec<RecordBatch>, mut f: F) ->
Result<()>
Review Comment:
Since this is a *pub** API, it would be best if we could keep the old API,
mark it as deprecated, and add a new API with the changed arguments
##########
datafusion/physical-plan/src/repartition/mod.rs:
##########
@@ -233,11 +233,11 @@ impl BatchPartitioner {
///
/// The time spent repartitioning, not including time spent in `f` will be
recorded
/// to the [`metrics::Time`] provided on construction
- pub fn partition<F>(&mut self, batch: RecordBatch, mut f: F) -> Result<()>
+ pub fn partition<F>(&mut self, batches: Vec<RecordBatch>, mut f: F) ->
Result<()>
Review Comment:
Since this is a **pub** API, it would be best if we could keep the old API,
mark it as deprecated, and add a new API with the changed arguments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
