adriangb commented on code in PR #15769: URL: https://github.com/apache/datafusion/pull/15769#discussion_r2051614507
########## datafusion/sqllogictest/test_files/aggregate.slt: ########## @@ -5006,7 +5006,7 @@ SELECT column5, avg(column1) FROM d GROUP BY column5; query I?? SELECT column5, column1, avg(column1) OVER (PARTITION BY column5 ORDER BY column1 ROWS BETWEEN 1 PRECEDING AND CURRENT ROW) as window_avg -FROM d WHERE column1 IS NOT NULL; +FROM d WHERE column1 IS NOT NULL ORDER BY column5 DESC; Review Comment: Without this in place the order of the rows changed. I'm not sure why, but I also don't think anything guarantees it without an `ORDER BY` clause so it seemed sensible to add one. A second opinion would be valuable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
