kumarlokesh commented on PR #15644:
URL: https://github.com/apache/datafusion/pull/15644#issuecomment-2817176100
> > thanks @kumarlokesh The code now looks much more aligned.
> > perhaps we can factor out
> > ```
> > self.parser
> > .parse_statement()
> > .map(|stmt|
Statement::Statement(Box::from(stmt)))
> > .map_err(|e| match e {
> > ParserError::RecursionLimitExceeded => {
> > DataFusionError::SQL(
> >
ParserError::RecursionLimitExceeded,
> > Some(format!(
> > " (current limit: {})",
> > self.options.recursion_limit
> > )),
> > )
> > }
> > other => DataFusionError::SQL(other,
None),
> > })
> > ```
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > into helper method
> > But it can be done in followup PR
>
> +1 for this to reduce duplicated code
@comphead @xudong963 addressed here
https://github.com/apache/datafusion/pull/15644/commits/dea5fe578e8f5e363b739981bb0ec45b2e3a55ba.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
