2010YOUY01 commented on PR #15782: URL: https://github.com/apache/datafusion/pull/15782#issuecomment-2817587293
Thanks, I think it's good to go after adding some simple docs for such configurations, in: https://github.com/apache/datafusion/tree/main/benchmarks and also the output of `./bench.sh help` I think it's also great if we could add some output to show the actual set configurations like ``` export DATAFUSION_EXECUTION_TARGET_PARTITIONS=1 export DATAFUSION_EXECUTION_FOO=1 ./bench.sh run tpch ``` Terminal output: ``` Set datafusion.execution.target_partitions to 1 from the environment variable ... start running the benchmark ``` We can just only an issue for it now, and leave it as a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
