xudong963 commented on PR #15786: URL: https://github.com/apache/datafusion/pull/15786#issuecomment-2818070749
> LGTM! I’ve left a few queries that might potentially require `rowsort`: > > https://github.com/apache/datafusion/blob/8a193c22f6c3f771bff16cb8f9608d764d268c59/datafusion/sqllogictest/test_files/aggregate.slt#L5227-L5229 > > https://github.com/apache/datafusion/blob/8a193c22f6c3f771bff16cb8f9608d764d268c59/datafusion/sqllogictest/test_files/aggregate.slt#L5251-L5253 > > https://github.com/apache/datafusion/blob/8a193c22f6c3f771bff16cb8f9608d764d268c59/datafusion/sqllogictest/test_files/aggregate.slt#L5286-L5288 > > https://github.com/apache/datafusion/blob/8a193c22f6c3f771bff16cb8f9608d764d268c59/datafusion/sqllogictest/test_files/aggregate.slt#L5336-L5338 Thank you, I opened a good first issue, let's fix the main ci first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
