goldmedal commented on PR #15334: URL: https://github.com/apache/datafusion/pull/15334#issuecomment-2818265303
> @goldmedal I don't understand this change. Previously, we have a sql: > > ``` > select * from t > where (select sid from t) = (select a from t limit 1) > order by ts > ``` The `ScalarSubquery` will be transformed by `ScalarSubqueryToJoin` to a left join, and then this PR forces the left join to have a condition. So, in this PR, I added the `True` expression for the left join in `ScalarSubqueryToJoin`. I think the result is expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
