blaginin opened a new issue, #15791: URL: https://github.com/apache/datafusion/issues/15791
In https://github.com/apache/datafusion/issues/15178, we're switching hard-coded constants in tests to `insta`. This issue targets updating **core tests** (`datafusion/core`). Examples of tests that need to be switched to `insta` - https://github.com/apache/datafusion/blob/91ad9fda2652f584d786a964ee205829e7a84580/datafusion/core/tests/sql/explain_analyze.rs#L177 - https://github.com/apache/datafusion/blob/91ad9fda2652f584d786a964ee205829e7a84580/datafusion/core/tests/sql/explain_analyze.rs#L211 - https://github.com/apache/datafusion/blob/91ad9fda2652f584d786a964ee205829e7a84580/datafusion/core/tests/sql/explain_analyze.rs#L72 has to be smart about that one as it only tests that plan contains some part - you may want to check [redactions](https://insta.rs/docs/redactions/) for that - https://github.com/apache/datafusion/blob/91ad9fda2652f584d786a964ee205829e7a84580/datafusion/core/tests/expr_api/simplification.rs#L296 - https://github.com/apache/datafusion/blob/91ad9fda2652f584d786a964ee205829e7a84580/datafusion/core/tests/physical_optimizer/enforce_sorting.rs#L265 ... and so on - check `assert_optimized!` `DataSourceExec:`, `assert_optimized_in_all_boundedness_situations` Check [the original issue](https://github.com/apache/datafusion/issues/15178) for tips on how to do the switch and examples of completed PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
